New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added order_by() to SqlaTable to ensure alphabetically ordered filter options values. #4712
Conversation
I feel like this should be done on the backend. From my experience it's been sorted, I'm guessing the |
We should add an and get the database to do the work. |
Added order_by to SqlaTable model
Well, in terms of database in use, I just popped open the dev setup. Non-alphabetical values can be spotted by setting up a dev environment using the test data as per the documentation. I rolled back the client side array sort and instead added an This is also a valid solution 👍 |
Codecov Report
@@ Coverage Diff @@
## master #4712 +/- ##
=======================================
Coverage 76.96% 76.96%
=======================================
Files 44 44
Lines 8534 8534
=======================================
Hits 6568 6568
Misses 1966 1966
Continue to review full report at Codecov.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Added
order_by(column_name)
to SqlaTable model to ensure correctly ordered value choices in filter controls.